fix: remove eager workspace expansion that negated module-scoping#50
Merged
aviadshiber merged 1 commit intomainfrom Apr 11, 2026
Merged
fix: remove eager workspace expansion that negated module-scoping#50aviadshiber merged 1 commit intomainfrom
aviadshiber merged 1 commit intomainfrom
Conversation
The _lazy_start_jdtls function was calling _expand_workspace_background() immediately after jdtls initialized, which added the full monorepo root and removed the initial module — undoing the module-scoping optimization from #46 and causing 120s initialize timeouts on large workspaces. Changes: - Remove eager expansion; modules load on-demand via add_module_if_new() - Gate READY signal on publishDiagnostics (reliable indexing-complete signal) instead of first non-None response - Add _start_failed retry with 5-minute cooldown so transient failures don't permanently disable jdtls for the session Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_expand_workspace_background()call from_lazy_start_jdtls— it was adding the full monorepo root and removing the initial module immediately after init, undoing the module-scoping optimization from feat: lazy module-scoped jdtls initialization with incremental loading #46publishDiagnosticsfrom jdtls (reliable indexing-complete signal) instead of first non-None response_start_failedretry with 5-minute cooldown so transient failures don't permanently disable jdtlsDesign Review
4-agent ensemble review (scope, security, scalability, devil's advocate). Key insight from devil's advocate:
expand_full_workspacenegates the entire module-scoping optimization — for agents working on 1-3 files, on-demandadd_module_if_newis sufficient.Test plan
🤖 Generated with Claude Code